InsightSoftwareConsortium / ITKThickness3D

An ITK module to compute 3D thickness
Apache License 2.0
39 stars 18 forks source link

itkMorphologicalDistanceTransformImageFilter instead of itkSignedMaurerDistanceMapImageFilter #23

Open romangrothausmann opened 5 years ago

romangrothausmann commented 5 years ago

Is there a particular reason to use itkSignedMaurerDistanceMapImageFilter https://github.com/InsightSoftwareConsortium/ITKThickness3D/blob/2539b34e4b43fd9369a0ad961c4811f2f329c0e4/include/itkMedialThicknessImageFilter3D.h#L23 instead of e.g. itkMorphologicalDistanceTransformImageFilter (which would be multi-threaded)? Why signed DM? Are there cases where the skeleton reaches outside of the binary image?

T4mmi commented 5 years ago

Hi @romangrothausmann

Nope there is not, it's just that it seemed like the less biased distance transform at the time I implemented it (but I didn't spend so much time on the benchmark).
If the MorphologicalDistanceTransformImageFilter is faster and unbiased we should use it :)

Another way would be to add some setter for distance algorithm customization ...

thewtex commented 1 year ago

CC @sbonaretti