InsightSoftwareConsortium / itk-dreg

A framework for distributed large-scale image registration
http://itk-dreg.readthedocs.io/
Apache License 2.0
5 stars 2 forks source link

Implement registration framework #6

Closed tbirdso closed 10 months ago

tbirdso commented 10 months ago

Implements the itk-dreg out-of-memory registration framework. Includes installable modules, testing, and examples.

Refer to updated README and CONTRIBUTING documentation along with notebook examples to get started.

Deferred: Deferred to https://github.com/InsightSoftwareConsortium/itk-dreg/issues/7: Run distributed with LocalCluster. Depends on https://github.com/InsightSoftwareConsortium/ITK/issues/4267.

cc @thewtex

thewtex commented 10 months ago

stitch_reduce -> displacement_field_reduce

thewtex commented 10 months ago

dask array argument -> chunk size specification that is used for internal dask array construction

thewtex commented 10 months ago

Add a comment noting that the current readers / writers will work with any itk-supported image type, but streaming will require a streaming supported reader, e.g. uncompressed MetaImage or Zarr.

tbirdso commented 10 months ago

@thewtex Following up from discussion yesterday, documentation on the Dask "threads" scheduler is here: https://docs.dask.org/en/stable/scheduling.html#local-threads

Parallelism occurs within a single process. I have not run benchmarks to determine whether we are seeing speedup with ITKElastix between "synchronous" and "threads" scheduling.

tbirdso commented 10 months ago

@thewtex Ping: this PR is ready for review and then merge. Additions are significant, I leave it up to you to decide how closely you'd like to do code review following our previous walkthroughs together offline.