InsightSoftwareConsortium / itkwidgets

An elegant Python interface for visualization on the web platform to interactively generate insights into multidimensional images, point sets, and geometry.
https://itkwidgets.readthedocs.io/
Apache License 2.0
579 stars 83 forks source link

Update conda package #643

Open brey opened 1 year ago

brey commented 1 year ago

The conda package supports only python <= 3.8. In order to update, afaik, the upstream path starts from itk.

Please check and accept https://github.com/conda-forge/itk-feedstock/pull/36 so that the work on the itkwidgets update can continue.

Otherwise, could you please provide a roadmap for updating the conda option.

Thanks

thewtex commented 1 year ago

@brey is it possible to help update the conda package to the 1.0aX version? This removes the direct dependency on itk.

brey commented 1 year ago

@thewtex I can give it a try. However, I see itk in the environment.yml even for 1.0aX version. How is it that the dependency is avoided?

thewtex commented 1 year ago

@brey thanks!

The environment.yml contains all the packages required for the examples -- the package does not require them.

Required dependencies are here:

https://github.com/InsightSoftwareConsortium/itkwidgets/blob/662ce4f7e4c5f3611e5136408988fc148365aba4/pyproject.toml#L38-L46

Optional dependencies are here:

https://github.com/InsightSoftwareConsortium/itkwidgets/blob/662ce4f7e4c5f3611e5136408988fc148365aba4/pyproject.toml#L63-L80

brey commented 1 year ago

@thewtex It seems that itkwasm, imjoy and ngff all lack a conda package. It shouldn't be difficult to create one for them using npm and/or the pip package. If you are ok with it, I could give it a try.

However, in the meantime and just to make sure that I can use itkwidgets in my next release, can you merge the itk PR above so that I can build the 0.32.x version?

thewtex commented 1 year ago

merge the itk PR above

Done -- thank you so much!

I could give it a try.

Yes -- thank you! You are doing amazing work, @brey :clap:

brey commented 1 year ago

Thanks @thewtex. I would suggest that you merge now the PRs that the bot made in itkwidget-feedstock here. This way my immediate problem would be solved since the same version I am using in py3.8 would be available for py3.11.

I will then make a PR for the latest 0.32.x version (if the bot doesn't bit me to it).

After that, the bot should take care of future releases if any.

I will then work on the 1.0.a26 dependencies. If I manage to build it locally, I can push it, when it's time, on the feedstock to replace the current recipe. I assume that once version 1 is released there will be no more 0.32.x releases.

Cheers

thewtex commented 1 year ago

merge now the PRs that the bot made in itkwidget-feedstock here

Done.

Are you willing to be added as a maintainer on these feedstocks?

I will then make a PR for the latest 0.32.x version (if the bot doesn't bit me to it).

I will then work on the 1.0.a26 dependencies.

Thank you!

I assume that once version 1 is released there will be no more 0.32.x releases.

Correct.

brey commented 1 year ago

@thewtex I have used the bot to update the version to the latest. You can merge https://github.com/conda-forge/itkwidgets-feedstock/pull/56 for completing the process.

Also thanks for the invitation to become a maintainer but I can help either way and my plate is full with the maintenance of my packages.

I will work on the new version as discussed and let you know. We can leave this issue open in order to communicate about it.

brey commented 1 year ago

@thewtex It took me awhile to figure out that version 0.32.x doesn't work with traitlets>5.6.0. I have also seen since that you have also pinned ipydatawidgets<4.3.3.

If these are here to stay we should include them in the conda recipe to avoid issues like those I had.

Let me know.

thewtex commented 1 year ago

@brey yes, makes sense.

brey commented 1 year ago

@thewtex I have updated the recipe. The PR in ready for merging here.