search

InsightSoftwareConsortium / itkwidgets

An elegant Python interface for visualization on the web platform to interactively generate insights into multidimensional images, point sets, and geometry.
https://itkwidgets.readthedocs.io/
Apache License 2.0
574 stars 83 forks source link

Roi image #710

Closed bnmajor closed 7 months ago

bnmajor commented 7 months ago

Add support for requesting an NgffImage of the current ROI

review-notebook-app[bot] commented 7 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] commented 7 months ago

View / edit / reply to this conversation on ReviewNB

thewtex commented on 2023-12-14T15:13:04Z ----------------------------------------------------------------

Line #3.    from ngff_zarr import to_multiscales, itk_image_to_ngff_image, to_ngff_image, Methods

add ngff_image_to_itk_image,remove itk_image_to_ngff_image and to_ngff_image


_bnmajor commented on 2023-12-14T15:43:33Z_ ----------------------------------------------------------------

Fixed

review-notebook-app[bot] commented 7 months ago

View / edit / reply to this conversation on ReviewNB

thewtex commented on 2023-12-14T15:13:05Z ----------------------------------------------------------------

Line #1.    image = itk.imread(file_name)

Remove lines 2 and 3 here


_bnmajor commented on 2023-12-14T15:43:35Z_ ----------------------------------------------------------------

Removed

review-notebook-app[bot] commented 7 months ago

View / edit / reply to this conversation on ReviewNB

thewtex commented on 2023-12-14T15:13:06Z ----------------------------------------------------------------

Line #1.    viewer = view(multiscales)

view(image)

Keep the screenshot with the ROI selection


review-notebook-app[bot] commented 7 months ago

View / edit / reply to this conversation on ReviewNB

thewtex commented on 2023-12-14T15:13:07Z ----------------------------------------------------------------

Line #2.    roi_region = viewer.get_roi_region()

Let's put this section after the get_roi_image section


_bnmajor commented on 2023-12-14T15:44:11Z_ ----------------------------------------------------------------

Moved

review-notebook-app[bot] commented 7 months ago

View / edit / reply to this conversation on ReviewNB

thewtex commented on 2023-12-14T15:13:08Z ----------------------------------------------------------------

Line #1.    viewer2 = view(roi_image, rotate=True)

Add a cell that that calls ngff_image_to_itk_image


review-notebook-app[bot] commented 7 months ago

View / edit / reply to this conversation on ReviewNB

thewtex commented on 2023-12-14T15:13:09Z ----------------------------------------------------------------

Line #7.    viewer3 = view(roi_image, rotate=True)

this cell and the one above can be removed


bnmajor commented 7 months ago

Fixed

View entire conversation on ReviewNB

bnmajor commented 7 months ago

Removed

View entire conversation on ReviewNB

bnmajor commented 7 months ago

Moved

View entire conversation on ReviewNB

bnmajor commented 7 months ago

View / edit / reply to this conversation on ReviewNB

thewtex commented on 2023-12-14T15:13:09Z ----------------------------------------------------------------

Line #7. viewer3 = view(roi_image, rotate=True) this cell and the one above can be removed

Just to clarifty: we don't want the viewer3 example at all anymore, correct?

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.