Closed Chris-N-K closed 2 years ago
@ch-n wonderful, thanks for the update!
Any tips on updates for the CI configuration?
I'm sorry but I'm not sure what CI stands for.
Thanks for the clarification. Did not take a look at the test_and_deploy script. There are some changes. I guess I should include them if nothing speaks against it. Other then that I have no tips. I'm no expert in this regard.
Did not take a look at the test_and_deploy script. There are some changes. I guess I should include them if nothing speaks against it.
@ch-n yes, wherever you found these updates, there are also likely updates to the .github/workflow/*
files that we could include so the automated continuous integration (CI) testing checks will pass.
@thewtex I'm not 100% certain but I could have found the issue why the tests were not running. Guess I should have read the error report more intensely. Github changed its handling of access quite some time ago. All this could be an violation of the current access routines. I changed the repo address from git: to https:. If we are lucky it's all fine now.
Merging #5 (83691c5) into main (6f3c9f8) will decrease coverage by
1.59%
. The diff coverage is75.00%
.
@@ Coverage Diff @@
## main #5 +/- ##
==========================================
- Coverage 89.47% 87.87% -1.60%
==========================================
Files 4 4
Lines 133 132 -1
==========================================
- Hits 119 116 -3
- Misses 14 16 +2
Impacted Files | Coverage Δ | |
---|---|---|
napari_itk_io/_reader.py | 70.58% <ø> (-2.39%) |
:arrow_down: |
napari_itk_io/_writer.py | 55.55% <71.42%> (-15.88%) |
:arrow_down: |
napari_itk_io/__init__.py | 66.66% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6f3c9f8...83691c5. Read the comment docs.
Well I forgot to update the tox testing env in the tox.ini. Next try...
I will close this pull request und try to build it from scratch hope it will work out...
As the plugin had some issues with the newest napari version (0.4.14) I updated it to the new napari plugin engine 2. Now everything works fine again and the plugin is ready for future napari releases.