search

Insightly / insightly-ruby

Ruby Library for the Insightly REST API
16 stars 45 forks source link

Add specs for GET #2

Closed dior001 closed 10 years ago

dior001 commented 10 years ago

Adds specs for any resource with a single GET e.g. GET /v2.1/Emails/{id}

dior001 commented 10 years ago

Hi @brianinsightly. I wanted to familiarize myself with the gem codebase so I went through and filled out some of the specs based on the existing pattern e.g. user_spec.rb.

brianinsightly commented 10 years ago

Hi David,

I've copied Alexander, who worked on the Ruby library, so you can communicate directly with him. Feel free to share suggestions, bug fixes, etc with Alexander, and we can incorporate those into the next revision of the library.

Alexander, David is one of our customers and is working with the library.

Thanks!

Brian McConnell

On Thu, Aug 21, 2014 at 8:34 PM, David Iorns notifications@github.com wrote:

Hi @brianinsightly https://github.com/brianinsightly. I wanted to familiarize myself with the gem codebase so I went through and filled out some of the specs based on the existing pattern e.g. user_spec.rb. If this code is not useful feel free to reject it. I'm seeing a problem where the class the spec is describing cannot be found. I've been unable to solve that so the specs aren't currently passing. An example of the error is uninitialized constant Insightly::Resources::Contact (NameError) . My current guess is that it's an autoloader problem possibly in spec_helper.rb. If there's something more useful I can contribute please let me know. I notice at the moment there are no PUT or POST implementations. Do you have an ETA on when those are going to be added?

— Reply to this email directly or view it on GitHub https://github.com/Insightly/ruby/pull/2#issuecomment-53007191.

dior001 commented 10 years ago

@alsemyonov please review.