Improved incorrect name display

Pantera07 commented 1 year ago

Describe the Feature

______komq_____ This name gets underscored and the name gets weirdly changed.

Provide Reasoning

The player's name must be displayed as is.

Checklist

[X] I have searched the issue tracker to ensure there are no similar feature requests
[X] I have read the wiki to ensure this isn't already possible
[ ] I ticked all of the boxes without actually reading them

Insprill commented 1 year ago

That's a pretty uncommon username, and this has to do with what formatter you're using. Minedown is the default, where __text__ is the syntax to underline text. You can disable the underline formatter for usernames by doing ...[%displayname%](format=!underlined). Check out the formatting page of the wiki for more information.

Pantera07 commented 1 year ago

I tried that and it gives an error.

[03:02:43 ERROR]: Could not pass event PlayerJoinEvent to CustomJoinMessages v17.2.2
java.lang.IllegalArgumentException: No enum constant net.md_5.bungee.api.ChatColor.UNDERLINED
        at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145) ~[guava-31.1-jre.jar:?]
        at net.md_5.bungee.api.ChatColor.valueOf(ChatColor.java:289) ~[bungeecord-chat-1.16-R0.4-deprecated+build.6.jar:?]
        at net.insprill.cjm.libs.de.themoep.minedown.MineDownParser.parseColor(MineDownParser.java:863) ~[Custom-Join-Messages-17.2.2.jar:?]
        at net.insprill.cjm.libs.de.themoep.minedown.MineDownParser.parseEvent(MineDownParser.java:551) ~[Custom-Join-Messages-17.2.2.jar:?]
        at net.insprill.cjm.libs.de.themoep.minedown.MineDownParser.parse(MineDownParser.java:287) ~[Custom-Join-Messages-17.2.2.jar:?]
        at net.insprill.cjm.libs.de.themoep.minedown.MineDown.toComponent(MineDown.java:137) ~[Custom-Join-Messages-17.2.2.jar:?]
        at net.insprill.cjm.libs.de.themoep.minedown.MineDown.parse(MineDown.java:112) ~[Custom-Join-Messages-17.2.2.jar:?]
        at net.insprill.cjm.formatting.MinedownFormatter.format(MinedownFormatter.kt:9) ~[Custom-Join-Messages-17.2.2.jar:?]
        at net.insprill.cjm.message.types.ChatMessage.formatMessages(ChatMessage.kt:37) ~[Custom-Join-Messages-17.2.2.jar:?]
        at net.insprill.cjm.message.types.ChatMessage.handle(ChatMessage.kt:18) ~[Custom-Join-Messages-17.2.2.jar:?]
        at net.insprill.cjm.message.MessageSender.trySendMessages$lambda$3(MessageSender.kt:73) ~[Custom-Join-Messages-17.2.2.jar:?]
        at net.insprill.cjm.message.MessageSender.trySendMessages(MessageSender.kt:75) ~[Custom-Join-Messages-17.2.2.jar:?]
        at net.insprill.cjm.listener.JoinEvent.onPlayerJoin(JoinEvent.kt:21) ~[Custom-Join-Messages-17.2.2.jar:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor286.execute(Unknown Source) ~[?:?]
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77) ~[purpur-api-1.19.3-R0.1-SNAPSHOT.jar:?]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:76) ~[purpur-api-1.19.3-R0.1-SNAPSHOT.jar:git-Purpur-1933]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[purpur-api-1.19.3-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[purpur-1.19.3.jar:git-Purpur-1933]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:126) ~[purpur-1.19.3.jar:git-Purpur-1933]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:617) ~[purpur-api-1.19.3-R0.1-SNAPSHOT.jar:?]
        at net.minecraft.server.players.PlayerList.placeNewPlayer(PlayerList.java:319) ~[purpur-1.19.3.jar:git-Purpur-1933]
        at net.minecraft.server.network.ServerLoginPacketListenerImpl.placeNewPlayer(ServerLoginPacketListenerImpl.java:202) ~[?:?]
        at net.minecraft.server.network.ServerLoginPacketListenerImpl.handleAcceptedLogin(ServerLoginPacketListenerImpl.java:183) ~[?:?]
        at net.minecraft.server.network.ServerLoginPacketListenerImpl.tick(ServerLoginPacketListenerImpl.java:85) ~[?:?]
        at net.minecraft.network.Connection.tick(Connection.java:594) ~[?:?]
        at net.minecraft.server.network.ServerConnectionListener.tick(ServerConnectionListener.java:233) ~[?:?]
        at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1594) ~[purpur-1.19.3.jar:git-Purpur-1933]
        at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:488) ~[purpur-1.19.3.jar:git-Purpur-1933]
        at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1424) ~[purpur-1.19.3.jar:git-Purpur-1933]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1194) ~[purpur-1.19.3.jar:git-Purpur-1933]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:321) ~[purpur-1.19.3.jar:git-Purpur-1933]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]

Pantera07 commented 1 year ago

https://github.com/Phoenix616/MineDown/pull/25

Since custom-join-messages is using an older version of MineDown, use (format=!underline) instead of (format=!underlined) and you won't get an error. However, the underline display still appears.

reproduce: [______komq_____](format=!underline)

Insprill commented 1 year ago

CJM is using MineDown 1.7.1-SNAPSHOT which is the latest version. Either way, this would be an issue with MineDown, not CJM.

Insprill / custom-join-messages