Insprill / custom-join-messages

Feature-packed plugin for handling all join and quit notifications on Spigot/Paper servers
https://modrinth.com/plugin/custom-join-messages/
GNU General Public License v3.0
10 stars 0 forks source link

Disable data logging #41

Closed Pantera07 closed 1 year ago

Pantera07 commented 1 year ago

Describe the Feature

  1. Disable worlds.json logging when World-Based-Messages is disabled.
  2. I don't know what toggles.json is for.

Provide Reasoning

Disabling toggles.json and worlds.json logging should give you some performance benefit.

Checklist

Insprill commented 1 year ago

The worlds.json file doesn't get updated when world-based messages are disabled. Does it get created? Yes. But no data is ever written to, or read from it.

The toggles.json file is for storing what players have enabled/disabled messages. Run /cjm help for more information.

Changing either of these wouldn't give a performance benefit. Before wanting to change things for performance, see if there's actually a need for it. Unless your server has noticeable lag spikes and you've used spark to narrow it down to my plugin writing to a file, you don't have an issue.

Pantera07 commented 1 year ago

Players' UUIDs are being recorded in worlds.json even when World-Based-Messages is disabled.