Insprill / custom-join-messages

Feature-packed plugin for handling all join and quit notifications on Spigot/Paper servers
https://modrinth.com/plugin/custom-join-messages/
GNU General Public License v3.0
10 stars 0 forks source link

Could not pass event PlayerJoinEvent to CustomJoinMessages v17.3.1 #52

Closed Ryoyo2 closed 9 months ago

Ryoyo2 commented 9 months ago

Server Version

Purpur version git-Purpur-2132 (MC: 1.20.4)

CJM Version

17.3.1

Describe the Bug

Upon joining the server myself (this doesn't seem to happen with every player), an error pops up. It seems that this error doesn't affect functioniality, however the console spam is a bit annoying. Error is in the attached log. If further information is required, please reply to this thread.

Expected Behavior

No error.

Steps to Reproduce

Step 1: Join the server.

Server Logs

https://mclo.gs/5bZumkm

Additional Information

No response

Checklist

Insprill commented 9 months ago

It looks like a config error. Can you send your chat message config?

Ryoyo2 commented 9 months ago

That is entirely possible. I took some values/placeholders i had in the plugin from back in 2021 after putting my server back online a couple days ago. I believe I only modified the chat.yml. All other yml's are set to false.

https://mclo.gs/hqMjT9n

Insprill commented 9 months ago

You have a syntax error on line 40. There needs to be a space between the hyphen and the quotes. So instead of

Messages:
  1:
    -""

it needs to be

Messages:
  1:
    - ""

You can remove the entire Join section if you don't need it.

Ryoyo2 commented 9 months ago

Thank you for the quick help! This fixed it. Apologies for not seeing it myself.

There is one last thing that I actually originally wanted to bring to your attention beforehand because I saw it in the reviews section if I am not mistaken. It is not a huge deal but the console spam is again just mildly annoying. If you know any remedy there, that would be great as well.

https://mclo.gs/dTogZlY

Insprill commented 9 months ago

Please open a separate issue for that and I'll get to it soon - it's most likely a simple fix so it shouldn't take long.