search

Insprill / custom-join-messages

Feature-packed plugin for handling all join and quit notifications on Spigot/Paper servers
https://modrinth.com/plugin/custom-join-messages/
GNU General Public License v3.0
10 stars 0 forks source link

Add support for AdvancedVanish #56

Closed MrCipherUa closed 6 months ago

MrCipherUa commented 6 months ago

Server Version

git-Purpur-2035

CJM Version

17.4.1

Describe the Bug

When I stay in vanish while using AdvancedVanish and rejoin the server a message gets sent that I joined tha game.

Expected Behavior

It is expected that join message doesn't show up when I join while in a vanish state.

Steps to Reproduce

Step 1: Use the latest Custom Join Messages version Step 2: Use AdvancedVanish https://www.spigotmc.org/resources/advancedvanish.86036/ Step 3: Join the server

Server Logs

https://mclo.gs/VHYOose

Additional Information

No response

Checklist

Insprill commented 6 months ago

I've added support for Advanced Vanish on the dev branch. You can download the build here in the Artifacts section. Please try it out and let me know how it works!

MrCipherUa commented 6 months ago

I tried the newest build, advanced vanish works well now, but there is a critical bug now, basically when you leave the game it doesn't send the "player left the game" message in chat. I think my config is alright and I tested it on two different servers, could you try to reproduce it and fix it?

Insprill commented 6 months ago

I wasn't able to reproduce what you described. However, I did find another major bug with the implementation, which I've now fixed. You can download the updated build here; please let me know if it also fixed your problem.

MrCipherUa commented 6 months ago

I fixed the problem. There are no more bugs for me anymore, thanks for adding Advanced Vanish