search

Insrt-Finance / insrt-v2-contracts-audit

0 stars 0 forks source link

It will be impossible to change the mint multiplier and risk of a collection #13

Open 0x73696d616f opened 5 months ago

0x73696d616f commented 5 months ago

Description

PerpetualMintInternal::_setCollectionMintMultiplier() and PerpetualMintInternal::_setCollectionRisk() enfore that there are no pending mints. However, some mint attempts may fail due to a variety of reasons (even if the mentioned issues in this report are fixed, attackers may still perform gas bomb attacks when receiving ETH and revert the vrf callbacks.

Recommendation

Consider adding functions to forcefully remove pending vrf requests that have reverted.

CruzMolina commented 5 months ago

Resolved via https://github.com/Insrt-Finance/insrt-v2-contracts/commit/07f3ee018b3fc9030cc38f828225d8dccb35472d.