search

Insrt-Finance / insrt-v2-contracts

0 stars 3 forks source link

Maximum depositor guard #120

Open CruzMolina opened 1 year ago

CruzMolina commented 1 year ago

We probably need to determine a reasonable cap of maximum depositors per collection and maximum active tokens per collection so that mint resolutions succeed 99% of the time.

Related to #105 & #112.

NouDaimon commented 1 year ago

Seems like a small issue for V1 - we will most likely not be hitting that limit, unless we gain PMF; a good problem to have.

Perhaps we flag this for V2?

Alternatively, it seems the way to do that is to identify gas costs for a single loop iteration of selectToken and selectDepositor.

Those are the bottlenecks.

CruzMolina commented 1 year ago

Linking this to #121 since it seems to be related to the problem of ensuring & resolving mint fulfillment requests. https://github.com/Insrt-Finance/insrt-v2-contracts/issues/121#issuecomment-1686534895

NouDaimon commented 1 year ago

Splitting issue into two.