search

Insrt-Finance / insrt-v2-contracts

0 stars 3 forks source link

Reversion Tests should have explicit reversion expectations #136

Closed NouDaimon closed 1 year ago

NouDaimon commented 1 year ago

Currently some tests pass with an empty revet expectation like:

vm.expectRevert();.

If this can be specified eg:

vm.expectRevert(error.selector);

it should.

CruzMolina commented 1 year ago

All of those cases currently are EvmError errors. Foundry doesn't support testing explicitly for them at the moment.

NouDaimon commented 1 year ago

Awesome. Will close.