Insrt-Finance / insrt-v2-contracts

0 stars 3 forks source link

Refactor: Scaffold integrate new `PerpetualMintStorage.Layout` `DataTypes` into deposit flows #142

Closed CruzMolina closed 1 year ago

CruzMolina commented 1 year ago
CruzMolina commented 1 year ago

@NouDaimon Decided to chunk this by scaffolding the work out and updating each flow first one by one before deprecating the current code. Let me know your thoughts on the new DataTypes. I believe they cover everything we need so far in the core supply side/collection owner flows.

NouDaimon commented 1 year ago

@NouDaimon Decided to chunk this by scaffolding the work out and updating each flow first one by one before deprecating the current code. Let me know your thoughts on the new DataTypes. I believe they cover everything we need so far in the core supply side/collection owner flows.

The only comments I have are conversational; I'd urge consistency above all since this is the time to enforce it. Other than that the division of data structures makes sense and looks clean. Great work!

CruzMolina commented 1 year ago

Closing to revamp & focus on v0.1.0-alpha (PerpMint MVP V1 development).