Closed CruzMolina closed 1 year ago
@NouDaimon Decided to chunk this by scaffolding the work out and updating each flow first one by one before deprecating the current code. Let me know your thoughts on the new DataTypes
. I believe they cover everything we need so far in the core supply side/collection owner flows.
@NouDaimon Decided to chunk this by scaffolding the work out and updating each flow first one by one before deprecating the current code. Let me know your thoughts on the new
DataTypes
. I believe they cover everything we need so far in the core supply side/collection owner flows.
The only comments I have are conversational; I'd urge consistency above all since this is the time to enforce it. Other than that the division of data structures makes sense and looks clean. Great work!
Closing to revamp & focus on v0.1.0-alpha
(PerpMint MVP V1 development).
success
declaration & redundant return inVRFCoordinatorV2MockPlus.fulfillRandomWordsWithOverridePlus
DataTypes
DataTypes
intoPerpetualMintStorage.Layout
, add unifiedcollections
&collectionOwners
mappingsbeneficiary
toowner
indepositERC1155Assets
flows, prepL2AssetHandler
_handleLayerZeroMessage
logic for scaffoldingDataTypes
intoL2AssetHandler
_handleLayerZeroMessage
flow for ERC1155 asset deposits, set up as temporary scaffoldingL2AssetHandler_handleLayerZeroMessage
test_handleLayerZeroMessageERC1155Deposit
test case to test newDataTypes
logicbeneficiary
toowner
indepositERC721Assets
flows, prepL2AssetHandler
_handleLayerZeroMessage
logic for scaffoldingDataTypes
intoL2AssetHandler
_handleLayerZeroMessage
flow for ERC721 asset deposits, set up as temporary scaffoldingL2AssetHandler_handleLayerZeroMessage
test_handleLayerZeroMessageERC721Deposit
test case to test newDataTypes
logic