Insrt-Finance / insrt-v2-contracts

0 stars 3 forks source link

Deployment script for `Token` #182

Closed NouDaimon closed 1 year ago

NouDaimon commented 1 year ago
NouDaimon commented 1 year ago

Wondering how we should go about using the PrivateKey. I've read that perhaps reading it prior to broadcast is not best practice.

What are your thoughts?

NouDaimon commented 1 year ago

LGTM.

Wondering how we should go about using the PrivateKey. I've read that perhaps reading it prior to broadcast is not best practice. What are your thoughts?

Totally up to you. I'm comfortable with storing & reading from a .env file, but if you'd personally rather sign & send the contract deployment calldata using some other method, that sounds good as well.

If you're good with it so am I! I read something about this in the foundry docs and its the first foundry script I've ever written, so wanted to run it by you!