feat: ext-11-for-multiple-spin-games-ensure-multiple-vrf-calls-are-used

[giovannifranchi]

Changes implemented:

• A constant wish represents the standard number of words for oracle request (2) has been added
• All functions requiring _requestRandomWords() or _requestRandomWordsSupra() now perform a loop making a VRF request for each number of mints. The aforementioned functions are namely:

    1. _attemptBatchMintForEthWithEth()
    2. _processMintForEthWithEthAttemptSupra()
    3. _attemptBatchMintForEthWithMint()
    4. _attemptBatchMintForEthWithMintSupra_requestRandomWordsSupra()
    5. _attemptBatchMintForMintWithEth()
    6. _attemptBatchMintForMintWithEthSupra()
    7. _attemptBatchMintForMintWithMint()
    8. _attemptBatchMintForMintWithMintSupra()
    9. _attemptBatchMintWithEth()
    10. _attemptBatchMintWithEthSupra()
    11. _attemptBatchMintWithMint()
    12. _attemptBatchMintWithMintSupra()

• Due to a stack too deep error in compilation the function _attemptBatchMintWithMintSupra has been polished of some variables. The previous variables have been replaced either by direct function invocations or direct math computation in the most gas efficient way possible.
• Since the resolve mint functions don’t always receive a predictable number of words (some of those values are parametrised therefore changeable) in order to allow the protocol to be resilient to future parameter changes it has been decided to leave the already existing structure based on loops.

Additionally make prettier has been run

[0xinsi]

Using a uint8 instead of a uint256 actually increases the cost of operations since under the hood solidity converts the uint8 in uint256.

Indeed! I was curious whether it was materially different.

The code looks fine.

Do we have any idea how many mints may be done as a maximum until we hit OOG error?