search

Instabug / Instabug-Android

In-app feedback and bug reporting tool for apps.
https://instabug.com/
Other
190 stars 38 forks source link

Lint error: missing android.permission.POST_NOTIFICATIONS permission #449

Open joost-klitsie opened 1 year ago

joost-klitsie commented 1 year ago

Steps to Reproduce the Problem

Include Instabug 11.8.0 dependency run a lint check

Expected Behavior

Lint check runs just fine

Actual Behavior

Lint check returns error: Error: When targeting Android 13 or higher, posting a permission requires holding the POST_NOTIFICATIONS permission (usage from com.instabug.chat.notification.t) [NotificationPermission]

SDK Version

11.8.0

Android Version

target sdk 33

MohamedHefny commented 1 year ago

Hi @joost-klitsie Thank you for reporting this issue, we are working on updating this part of our SDK to fix this one very soon. Until now if you are using a custom lint configurations can you please share it with us?

joost-klitsie commented 1 year ago

@MohamedHefny we don't use custom lint rules (only some suppressions that are unrelated). This is the "out of the box" Android lint check. For example, running the gradle command lintDebug on the android project.

silarnab commented 2 months ago

Hi @joost-klitsie, Is this something which is being looked at now as the targetSdk version is now 34?

If the fix is not being prioritized, does it make sense to suppress the lint error for now so that lint checks of client apps do not error out due to this issue?