Instabug / Instabug-React-Native

In-app feedback and bug reporting tool for React Native
https://instabug.com/platforms/react-native
MIT License
308 stars 100 forks source link

fix: use correct string type in network diagnostics handler #1160

Closed a7medev closed 4 months ago

a7medev commented 4 months ago

Description of the change

The type of the data parameter in NetworkDiagnosticsHandler was set to String which is the object wrapper around the string type, this causes TypeScript errors when trying to assign data to a variable of type string. So we changed it to string.

Type of change

Related issues

Jira ID: INSD-11050

Checklists

Development

Code review

InstabugCI commented 4 months ago
Warnings
:warning: You have not included a CHANGELOG entry! You can find it at [CHANGELOG.md](https://github.com/Instabug/Instabug-React-Native/blob/master/CHANGELOG.md).

Coverage Report

Label Coverage Status
JavaScript 96.3%
Android 46.9%
iOS 42.2%

Generated by :no_entry_sign: dangerJS against ffa2a68f6072cac9f24f2f587a4e151a575b2e90