Instabug / Instabug-React-Native

In-app feedback and bug reporting tool for React Native

https://instabug.com/platforms/react-native

MIT License

309 stars 100 forks source link

fix(android): UIManagerModule Fix for Bridgeless #1236

Open arushikesarwani94 opened 3 months ago

arushikesarwani94 commented 3 months ago

Description of the change

https://github.com/Instabug/Instabug-React-Native/blob/master/android/src/main/java/com/instabug/reactlibrary/RNInstabugReactnativeModule.java#L925

will fail in Bridgeless mode React Native 0.74 on Android since this returns null in Bridgeless

https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.java#L600-L606

How

Implemented fallback in Bridgeless to UIManagerHelper

Type of change

[X] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

[ ] Lint rules pass locally
[ ] The code changed/added as part of this pull request has been covered with tests

Code review

[X] This pull request has a descriptive title and information useful to a reviewer
[ ] Issue from task tracker has a link to this pull request

arushikesarwani94 commented 3 months ago

cc: @ahmedAlaaInstabug for review