Instabug / Instabug-React-Native

In-app feedback and bug reporting tool for React Native
https://instabug.com/platforms/react-native
MIT License
308 stars 100 forks source link

fix(ios): report fatal crashes with the updated api #1290

Closed a7medev closed 1 week ago

a7medev commented 1 week ago

Description of the change

The API for reporting JavaScript crashes on iOS has been changed from Instabug.reportCrashWithStackTrace to CrashReporting.cp_reportFatalCrashWithStackTrace in the native iOS SDK as part of v13.1.0 but the React Native SDK wasn't updated to use the new API. This led to fatal JavaScript crashes being reported by the iOS SDK as native crashes rather than JavaScript crashes breaking symbolication for these crashes.

This PR updates the API to be the new one to fix this bug.

Type of change

Related issues

Jira ID: MOB-16163

Checklists

Development

Code review

InstabugCI commented 1 week ago

Coverage Report

Label Coverage Status
JavaScript 98.4%
Android 50.2%
iOS 49.2%

Generated by :no_entry_sign: dangerJS against 1f3f79ae1f54930f7f555b2b722af0aa532dab4d