Closed datur closed 1 year ago
Hi @datur!
Thank you for your pull request and welcome to our community.
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
Thanks for the review @amyreese I believe I have addressed your change requests now! Let me know if you have any other feedback 😄
Thank you!
Summary
I had suggested on issue https://github.com/Instagram/Fixit/issues/365 that it would be nice to automatically skip a file if no rules were enabled for a given file https://github.com/Instagram/Fixit/issues/365#issuecomment-1678542798.
To avoid unnecessary processing of files if no rules are enabled for a given file the config is now checked before processing a file and if no rules are enabled the file is skipped.
Test Plan
Two smoke tests have been added to confirm files are skipped if no rules are enabled.