Closed llllvvuu closed 10 months ago
Hi @llllvvuu!
Thank you for your pull request and welcome to our community.
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
CLA submitted
Just took a look at ufmt CLI and happy to make the changes. So to confirm, intended usage is
fixit lint - path/to/foo.py # formats stdin, treating it as if it is located at path/to/foo.py
Just took a look at ufmt CLI and happy to make the changes. So to confirm, intended usage is
fixit lint - path/to/foo.py # formats stdin, treating it as if it is located at path/to/foo.py
Correct :)
Just made the changes, thanks again for the ufmt reference!
I wasn't able to leave cli.py
100% unchanged since fixit fix
needs to disable --interactive
(as STDIN is occupied) and redirect Result
s to STDERR (as STDOUT is occupied). But let me know what you think
Thank you!
Similarly for
fixit fix
. The API is inspired by Prettier.Summary
Related to #122 but does not fully resolve it. It supports a lint-as-you-type workflow, whereas only a lint-on-save workflow could be supported before. Full resolution of #122 would require #387.
Test Plan
Extended smoke tests.