Instagram / Fixit

Advanced Python linting framework with auto-fixes and hierarchical configuration that makes it easy to write custom in-repo lint rules.
https://fixit.rtfd.io/en/latest/
Other
666 stars 62 forks source link

feat: add `fixit lsp` subcommand #390

Closed llllvvuu closed 4 months ago

llllvvuu commented 1 year ago

resolves #387 #122

Note: easier to read in unified view since it's new code. Note: uses the popular pygls (Apache 2.0) implementation of the protocol.

https://github.com/Instagram/Fixit/assets/5601392/2dcd7447-431e-49a9-a383-aa424d4fbc6b

Summary

Support for:

Not supported yet

If this PR gets merged I will create follow-up issues for these items.

Test Plan

Added new smoke test for the new fixit lsp subcommand.

amyreese commented 11 months ago

Sorry for the delay. I'll try to review this and your other PR's some time next week.

llllvvuu commented 10 months ago

No worries, might be delayed as I don't have Wi-fi this month, but I'm happy to make the changes as they all seem sensible!

llllvvuu commented 10 months ago

Updated, sorry for the delay!

povilasb commented 6 months ago

This is cool!

Hope it will get merged 🤞

amyreese commented 4 months ago

Thank you for contributing this work and for responding to feedback. Look forward to this being in a future release!