Closed llllvvuu closed 4 months ago
Sorry for the delay. I'll try to review this and your other PR's some time next week.
No worries, might be delayed as I don't have Wi-fi this month, but I'm happy to make the changes as they all seem sensible!
Updated, sorry for the delay!
This is cool!
Hope it will get merged 🤞
Thank you for contributing this work and for responding to feedback. Look forward to this being in a future release!
resolves #387 #122
Note: easier to read in unified view since it's new code. Note: uses the popular pygls (Apache 2.0) implementation of the protocol.
https://github.com/Instagram/Fixit/assets/5601392/2dcd7447-431e-49a9-a383-aa424d4fbc6b
Summary
Support for:
textDocument/didOpen
,textDocument/didChange
->textDocument/publishDiagnostics
textDocument/formatting
Not supported yet
textDocument/codeAction
,workspace/executeCommand
(possibly blocked on #352 #358)workspace/didChangeWatchedFiles
to invalidate the config cacheIf this PR gets merged I will create follow-up issues for these items.
Test Plan
Added new smoke test for the new
fixit lsp
subcommand.