search

Instagram / Fixit

Advanced Python linting framework with auto-fixes and hierarchical configuration that makes it easy to write custom in-repo lint rules.
https://fixit.rtfd.io/en/latest/
Other
666 stars 62 forks source link

Conventional file path/line number separator (`:` instead of `@`) #397

Closed samueljsb closed 1 month ago

samueljsb commented 11 months ago

The output when a line is reported uses the @ character to separate the filename from the line number, e.g:

path/to/some/module.py@91:12 An error is at this location.

This differs from most other tools, which use a colon. The colon syntax is understood by many other tools that parse output (e.g. mypy-json-report) and the file finder in most editors (e.g. VS Code). e.g:

path/to/some/module.py:91:12 An error is at this location.

Would the maintainers be open to changing the output format to be the same as other tools? It would (imo) make fixit output much easier to work with.

samueljsb commented 9 months ago

Would the maintainers be open to a PR that changes this? If there is a concern about backwards compatibility, would a --format option be acceptable?

meshy commented 7 months ago

This is related to https://github.com/Instagram/Fixit/issues/305

jvllmr commented 7 months ago

+1. When using with VSCode I would like the path/line/column link to lead me to the spot in the code instead of doing basically nothing