search

Instagram / Fixit

Advanced Python linting framework with auto-fixes and hierarchical configuration that makes it easy to write custom in-repo lint rules.
https://fixit.rtfd.io/en/latest/
Other
666 stars 62 forks source link

fixit upgrade makes incomplete fix, second run results in metadata error #406

Open amyreese opened 10 months ago

amyreese commented 10 months ago 
from fixit import CstLintRule

class FooRule(CstLintRule):
    ...
Traceback (most recent call last):
  File ../fixit/upgrade/remove_rule_suffix.py", line 58, in visit_ClassDef
    qname = metadata.pop().name
KeyError: 'pop from an empty set'
zsol commented 10 months ago

Hmm, metadata should never be mutated