search

Instagram / Fixit

Advanced Python linting framework with auto-fixes and hierarchical configuration that makes it easy to write custom in-repo lint rules.
https://fixit.rtfd.io/en/latest/
Other
659 stars 62 forks source link

Lintrule collections abc #460

Closed surge119 closed 1 month ago

surge119 commented 1 month ago

Summary

Since python 3.3, the Collections Abstract Base Classes (ABC) has been moved to the collections.abc module. This lint rule checks and fixes (some) ABC imports from collections to collections.abc.

Test Plan

The lint rule has several built in tests that were run using hatch run test

facebook-github-bot commented 1 month ago

Hi @surge119!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 1 month ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

amyreese commented 1 month ago

Thank you! 🥂