search

Instagram / IGListKit

A data-driven UICollectionView framework for building fast and flexible lists.
https://instagram.github.io/IGListKit/
MIT License
12.85k stars 1.54k forks source link

Cannot create cells from Nib in Cocoapods release #104

Closed yusuftor closed 7 years ago

yusuftor commented 7 years ago

Hi,

I saw that in your example project, you have the following code for creating a cell from a nib:

IGListSingleSectionController(nibName: NibCell.nibName,
                              bundle: nil,
                              configureBlock: configureBlock,
                              sizeBlock: sizeBlock)

However, in the version of IGListKit downloaded from Cocoapods, the function is no where to be seen. Would it be possible to update the Cocoapods version so that it has this function? Thanks!

rnystrom commented 7 years ago

@yusuftor we should! I'll bump a 1.1 release and include this

jessesquires commented 7 years ago

This needs to be 2.0, not 1.1.

This is a breaking change

jessesquires commented 7 years ago

@rnystrom - we should probably wait until current PRs are merged.

Since this is a breaking release, we should pack-in as many breaking changes as we can.

There's a 2.0 draft at https://github.com/Instagram/IGListKit/releases

jessesquires commented 7 years ago

@yusuftor you can track our progress for the next release here:

https://github.com/Instagram/IGListKit/milestone/1

rnystrom commented 7 years ago

@jessesquires actually #56 wasn't breaking, I meant cutting a 1.1.0 and picking the nib feature before we cut 2.0.0. What do you think?

jessesquires commented 7 years ago

Ahhh.. I see.

At this point, I think it's more valuable (and simpler) to just pack up everything into 2.0 and release that. Do we foresee any other major breaking changes coming up?

rnystrom commented 7 years ago

No I don't think so

jessesquires commented 7 years ago

Also, it's only been 13 days since 1.0 😄

I say we wait another week or two, keep merging PRs, then tag and release 2.0.

And honestly, master is pretty stable. If anyone needs those features right now, then they can point CocoaPods/Carthage there for now.

yusuftor commented 7 years ago

Ok so which branch should I be directing Cocoapods to to access those features?

Sherlouk commented 7 years ago

@yusuftor
Adding the following: pod 'IGListKit', :git => 'https://github.com/Instagram/IGListKit.git', :branch => 'master' to your Podfile should enable it to get the latest version of Master from the repository.

jessesquires commented 7 years ago

Yep -- although master is pretty stable (and tested), it should be used with caution 😄

jessesquires commented 7 years ago

Going to go ahead and close this out