Instagram / IGListKit

A data-driven UICollectionView framework for building fast and flexible lists.
https://instagram.github.io/IGListKit/
MIT License
12.84k stars 1.54k forks source link

Cannot compile iOS example app #1420

Open Ricardo1980 opened 4 years ago

Ricardo1980 commented 4 years ago

Hello,

I'm trying to compile the example apps following this guide: https://instagram.github.io/IGListKit/ I download the current IGListKit version, then I run "./scripts/setup.sh" but I see this error:

Setting up example projects...
Setting up iOS examples...
Analyzing dependencies
2020-01-19 14:46:39.693 defaults[10716:3505260] 
The domain/default pair of (/Users/ricardo/Downloads/IGListKit-master/Source/Info, CFBundleShortVersionString) does not exist
[!] The `IGListDiffKit` pod failed to validate due to 1 error:
    - ERROR | version: A version is required.

Any advice? What should I do to compile the iOS example app?

Thanks a lot.

New issue checklist

General information

sclcoder commented 4 years ago

I encountered the same problem. This may be caused by the MAC OS 10.15 shell. I'm not familiar with shell, I just used a little trick to solve this problem. After all, just run the demo, there is no need to spend too much time. Just modify the IGListDiffKit.podspec 、IGListKit.podspec、IGListSwiftKit.podspec files

s.version = scripts/version.sh to s.version = '4.1.0'

image

JackieQi commented 4 years ago

Just to highlight here. Fixed in this commit https://github.com/Instagram/IGListKit/pull/1423/commits/9253d54cc639759f6a7fc52fded80a95bac03c29

lorixx commented 4 years ago

Thanks for surfacing this @JackieQi !

richardtop commented 4 years ago

+1 definitely a demo project should take less than a minute to run.

yspreen commented 4 years ago

I see your PR was closed @damozhang, did you open a new one that complies to the repo's conventions?

To me, the master branch still creates this issue... Paging @JackieQi as well?

VincentSit commented 3 years ago

This issue is reproducible on macOS 11.1 / 11.2, @JackieQi 's patch does fix it.