IGListStackedSectionController deselectItemAtIndex:sectionController:animated bug

[jeffbailey]

New issue checklist

• [x] I have reviewed the README and documentation
• [x] I have searched existing issues and this is not a duplicate

General information

• IGListKit version: Current master
• iOS version(s): 10.1
• CocoaPods/Carthage version:
• Xcode version:8.1
• Devices/Simulators affected:
• Reproducible in the demo project? (Yes/No):No
• Related issues:

The current implementation is this:

- (void)deselectItemAtIndex:(NSInteger)index sectionController:(IGListSectionController<IGListSectionType> *)sectionController animated:(BOOL)animated {
    const NSUInteger localIndex = [self localIndexForSectionController:sectionController index:index];
    [self.collectionContext deselectItemAtIndex:localIndex sectionController:self animated:animated];
}

But I believe the correct implementation is:

- (void)deselectItemAtIndex:(NSInteger)index sectionController:(IGListSectionController<IGListSectionType> *)sectionController animated:(BOOL)animated {    
    const NSUInteger relativeIndex = [self relativeIndexForSectionController:sectionController fromLocalIndex:index];
    [self.collectionContext deselectItemAtIndex:relativeIndex sectionController:self animated:animated];
}

The index being passed to this method is already a local index, so it needs to be converted to an index relative to the Stacked Section Controller.

[rnystrom]

Yikes, yup! Spot on. Definitely a bug w/ stacked section controller.

[jeffbailey]

Great. IGListKit is brilliant BTW. Thanks for making it open source.

[rnystrom]

@jeffbailey that means the world to me