Instagram / IGListKit

A data-driven UICollectionView framework for building fast and flexible lists.
https://instagram.github.io/IGListKit/
MIT License
12.87k stars 1.54k forks source link

Is the document wrong for IGListSectionController? #432

Closed PhilCai1993 closed 7 years ago

PhilCai1993 commented 7 years ago

In IGListSectionController.h, the comment for

@property (nonatomic, weak, nullable) id <IGListScrollDelegate> scrollDelegate;

is

/**
 An object that handles display events for the section controller. Can be `nil`.

 @return An object that conforms to `IGListDisplayDelegate` or `nil`.

 @note You may wish to return `self` if your section controller implements this protocol.
 */

which is exactly the same as

@property (nonatomic, weak, nullable) id <IGListDisplayDelegate> displayDelegate;

Or is there some difference? Thanks~

rnystrom commented 7 years ago

@PhilCai1993 I'm loving your deep dives. Yes! This is wrong. It should be updated and describe the scrolling delegate instead.

PhilCai1993 commented 7 years ago

😄 We have added IGListKit into our Podfile. And I have to share it to my partners, so I took a a deep look at it.

Sherlouk commented 7 years ago

Closed by 6e00787