Open zaicruvoir1rominet opened 4 months ago
Attention: Patch coverage is 25.49020%
with 114 lines
in your changes missing coverage. Please review.
Project coverage is 91.29%. Comparing base (
8b97600
) to head (eb3f2a6
). Report is 9 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This seems like an improvement, thank you. It's really hard to catch a specific Exception
, I have to rely on its message. I hope this gets merged.
Thanks for the support @kiri11 ! You also made me realize some users were perhaps using exception messages in order to manage errors, so I kept all original Exception messages in order to avoid breaking changes.
I hope everything is now ready (apart from that CSTLogicError
file location & docstring)
You're welcome! (although I didn't do anything) Keeping the exception messages backwards-compatible is a great idea, thank you!
Summary
Before tackling issue #457, there are some bare Exceptions thrown from within the code.
Here is the logic for changes in Exceptions:
ValueError
when issue caused by user inputCSTValidationError
&TypeError
when issue occurs during the CST validation processParserSyntaxError
when issue occurs during the parsing processCSTLogicError
to replace all Exception which contained "Logic error" in the cause messageI'm all for changes if some Exceptions changes are not OK,
In particular, there are some
ParserSyntaxError
which may not be meaningful - with raw_line=0, raw_column=0 paramsTest Plan
Keep the current test plan.