Instagram / LibCST

A concrete syntax tree parser and serializer library for Python that preserves many aspects of Python's abstract syntax tree

https://libcst.readthedocs.io/

Other

1.56k stars 192 forks source link

ci: build wheels for musllinux #1243

Closed MrMino closed 1 week ago

MrMino commented 1 week ago

Summary

Allow CIBW to build wheels with -musllinux tags.

Alpine CIs could greatly benefit from having libcst available.

Closes #962

facebook-github-bot commented 1 week ago

Hi @MrMino!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 1 week ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

zsol commented 1 week ago

Thanks!

MrMino commented 1 week ago

@zsol I wasn't sure if this is it, hence the "Draft:" in the name - sorry for not using the Draft feature, I brain farted and thought this works similarly to GitLab.

It looks like it's still failing on rustup: https://github.com/Instagram/LibCST/actions/runs/11878027367/job/33098223245

MrMino commented 1 week ago

It looks like the i686-unknown-linux-musl is only tier-2 support in rustup (source) hence the missing installer. @zsol If I understand this correctly, given the aforementioned missing support in Rust, it is ok to skip the builds for that plat+arch?

Edit: my rustup target list actually shows i686-unknown-linux-musl as supported, not sure what's going on here. Maybe it's just a thing with the PyPA images? A missing package somewhere? 🤔

Edit 2: Apparently, in the world of Rust, there is a distinction between Tier 2 support with and without host tools, which I wasn't aware of. So we can cross-compile for i686+linux+musl, but we should not expect to be able to get a rustup/cargo/rustc that itself works on this triplet.

Given how niche triplet this is (apparently it's something mostly used by people who run iSH app on IPad to get a Linux shell there), I'd say: skip it. I'll PR that one in a sec.