Instagram / LibCST

A concrete syntax tree parser and serializer library for Python that preserves many aspects of Python's abstract syntax tree
https://libcst.readthedocs.io/
Other
1.56k stars 192 forks source link

ci: skip musllinux builds for unsupported archs #1244

Closed MrMino closed 1 week ago

MrMino commented 1 week ago

See #1243. CI started failing after pulling that change into main.

Summary

This fixes current CI failures by skipping Musl builds for i686, ppc64le, s390x, and armv7le architectures.

The failures are due to Rust ecosystem having only partial support / not having tool chains for these architectures. For the list of supported archs and tiers of support, see:

https://doc.rust-lang.org/nightly/rustc/platform-support.html

The architectures skipped here are either, from the Rust PoV:

MrMino commented 1 week ago

FTR I'm still waiting for the build to pass on my fork repo, to see if I haven't fatfingered any of the CIBW_SKIP patterns.

MrMino commented 1 week ago

For some reason cibuildwheel is still trying to set up a musllinux_1_2_i686 environment... This needs further fixing.

MrMino commented 1 week ago

Correction: turns out the GHAs in my fork were still using the upstream's build.yml file, so the failure I saw was actually a false positive - it just didn't use the changes I made here.

This is ready to be merged. Passing build jobs:

Kind nudge @zsol :)

zsol commented 1 week ago

Nice, thanks for following up :)