search

Instagram / ig-json-parser

Fast JSON parser for java projects
https://instagram-engineering.com/fast-auto-generated-streaming-json-parsing-for-android-ab8e7be21033
MIT License
1.32k stars 124 forks source link

Conflict on the JavaWriter class #15

Closed rtmvc closed 10 years ago

rtmvc commented 10 years ago

The JavaWriter from Square seems to be packaged directly into ig-json-parser jar without being moved or renamed. This seems to cause conflict with other libraries which need a more recent version JavaWriter such as Dagger.

Why not using an external dependency on JavaWriter instead? At worse repackaging it (at least during the build if this causes later merge issues)?

ttung commented 10 years ago

There are changes to the source. I will put it in a different package to avoid the conflict.

On Sep 25, 2014, at 2:15 PM, Ratamovic notifications@github.com<mailto:notifications@github.com> wrote:

The JavaWriter from Square seems to be packaged directly into ig-json-parser jar without being moved or renamed. This seems to cause conflict with other libraries which need a more recent version JavaWriter such as Dagger.

Why not using an external dependency on JavaWriter instead? At worse repackaging it (at least during the build if this causes later merge issues)?

— Reply to this email directly or view it on GitHubhttps://github.com/Instagram/ig-json-parser/issues/15.

rtmvc commented 10 years ago

Thx it would be great :-). Just out of curiosity, what kind of changes were needed?

ttung commented 10 years ago

https://github.com/Instagram/ig-json-parser/commit/4d6c69b5704a5caff88a71eafc3abac5a5c866d6

TommyVisic commented 10 years ago

By the way, not sure if this is a similar issue or not, but I ran into some conflicts w/ the the Jackson dependency between ig-parser and Amazon's aws-android-1.7.1.1 library. We worked around it by opening up the aws-android JAR and removing the built-in Jackson package.

ttung commented 10 years ago

similar issue, but the problem is with amazon instead.

ttung commented 10 years ago

I released a new artifact to maven central with this fix (and others).