search

Instagram / ig-json-parser

Fast JSON parser for java projects
https://instagram-engineering.com/fast-auto-generated-streaming-json-parsing-for-android-ab8e7be21033
MIT License
1.32k stars 125 forks source link

Add classpath to Javadoc tasks #23

Closed jle closed 9 years ago

jle commented 9 years ago

I had to add these classpaths to Javadoc tasks to get assemble to run

ttung commented 9 years ago

What happens without this diff? I've been building the docs without this change for a while. Wondering if there's something different about your or my environment that causes this.

jle commented 9 years ago

It probably is. I get these javadoc errors from master:

$ ./gradlew clean assemble

Produces:

 /Users/jle/code/ig-json-parser/common/src/main/java/com/instagram/common/json/JsonFactoryHolder.java:5: error: package com.fasterxml.jackson.core does not exist
import com.fasterxml.jackson.core.JsonFactory;
                                 ^
/Users/jle/code/ig-json-parser/common/src/main/java/com/instagram/common/json/JsonFactoryHolder.java:11: error: cannot find symbol
  public static final JsonFactory APP_FACTORY = new JsonFactory();
                      ^
  symbol:   class JsonFactory
  location: class JsonFactoryHolder
/Users/jle/code/ig-json-parser/processor/src/main/java/com/instagram/common/json/annotation/processor/JsonParserClassData.java:30: error: package com.fasterxml.jackson.core does not exist
import com.fasterxml.jackson.core.JsonGenerator;
                                 ^
/Users/jle/code/ig-json-parser/processor/src/main/java/com/instagram/common/json/annotation/processor/JsonParserClassData.java:31: error: package com.fasterxml.jackson.core does not exist
import com.fasterxml.jackson.core.JsonParser;
                                 ^
/Users/jle/code/ig-json-parser/processor/src/main/java/com/instagram/common/json/annotation/processor/JsonParserClassData.java:32: error: package com.fasterxml.jackson.core does not exist
import com.fasterxml.jackson.core.JsonToken;
                                 ^
/Users/jle/code/ig-json-parser/processor/src/main/java/com/instagram/common/json/annotation/processor/StrFormat.java:8: error: package org.apache.commons.lang3.text does not exist
import org.apache.commons.lang3.text.StrSubstitutor;
                                    ^

The build completes with "BUILD SUCCESSFUL" but spits out the above errors and a few other warnings. Let me know if you want me to try anything. Thanks!

jle commented 9 years ago

I see you've already made these changes in a separate commit so I'm going to close this.