search

Instagram / ig-json-parser

Fast JSON parser for java projects
https://instagram-engineering.com/fast-auto-generated-streaming-json-parsing-for-android-ab8e7be21033
MIT License
1.32k stars 124 forks source link

This library is not compatible JDK7 anymore #38

Closed anthony-skr closed 6 years ago

anthony-skr commented 7 years ago

As per gradle dependencies versions :

|    +--- com.instagram:ig-json-parser-processor:0.0.6
|    |    +--- com.fasterxml.jackson.core:jackson-core:[2.2.3,) -> 2.9.0-SNAPSHOT
|    |    +--- com.google.guava:guava:[12.0.1,) -> 21.0-SNAPSHOT
|    |    \--- org.apache.commons:commons-lang3:[3.1,) -> 3.5

ig-json-parser now will get Guava 21 which is only JDK8 compatible : The coming release (21.0) will require JDK 1.8, but we will begin providing a backport soon thereafter. (see https://github.com/google/guava).

It totally breaks apps running on JDK7.

ttung commented 7 years ago

Is this an issue? The processor can run on JDK8+ but the runtime library doesn't depend on Guava.

ttung commented 7 years ago

What errors are you seeing?

From: nacho007 notifications@github.com Sent: Tuesday, December 20, 2016 2:42:20 PM To: Instagram/ig-json-parser Cc: Tony Tung; Comment Subject: Re: [Instagram/ig-json-parser] This library is not compatible JDK7 anymore (#38)

Please fix!!! This is no longer compatible with JDK7!!!

- You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/Instagram/ig-json-parser/issues/38#issuecomment-268380492, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AARJXBi_Uzvv1pe6tU21alTW2CGxZFh9ks5rKFnMgaJpZM4KrH4m.

ttung commented 7 years ago

What error messages do you see? Can you post an example project?

From: nacho007 notifications@github.com Sent: Tuesday, December 20, 2016 3:22:19 PM To: Instagram/ig-json-parser Cc: Tony Tung; Comment Subject: Re: [Instagram/ig-json-parser] This library is not compatible JDK7 anymore (#38)

Cant use it. Says i need to support Java 1.7 but when I put the backward compatibility in gradle file nothing happens and doesnt compile. Try the JAR but with no luck!

- You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/Instagram/ig-json-parser/issues/38#issuecomment-268388376, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AARJXInNFkuaz_Ofkiw_fmKkHCWY_703ks5rKGMrgaJpZM4KrH4m.

kangzhang commented 6 years ago

we have updated the gradle configuration. closing, feel free to re-open if the error is still there.