search

Instagram / ig-json-parser

Fast JSON parser for java projects
https://instagram-engineering.com/fast-auto-generated-streaming-json-parsing-for-android-ab8e7be21033
MIT License
1.32k stars 124 forks source link

Support upcoming "source abi" feature of Buck #42

Closed dreiss closed 7 years ago

ttung commented 7 years ago

I think @tkieft or @Kang need to approve this.

kangzhang commented 7 years ago

The changes look good! I'll try merging this later.

Could we add some tests for it?

dreiss commented 7 years ago

Sure. I'll need to run the AP with that special parameter added. Do you know where would be the best place to integrate it?

kangzhang commented 7 years ago

Ah, yeah, I think it could be added in compiler args. e.g. https://github.com/Instagram/ig-json-parser/blob/master/processor/testuut/noserializers/build.gradle#L7

kangzhang commented 7 years ago

The ci config on master was broken due to changes on travis ci. I just updated the config and if you rebase the ci build should work again.

dreiss commented 7 years ago

Thanks for the pointer! Updated the first commit with tests based on the noserializers tests. The second one can't really be tested fully without the javac plugin in Buck.

kangzhang commented 7 years ago

Thanks for adding the test! Merging now.