InstantClientTap / homebrew-instantclient

A tap of Mac Homebrew formulas for Oracle Instant Client.
MIT License
80 stars 39 forks source link

Support for Oracle 18.1.0.0.0 #29

Closed onedr0p closed 5 years ago

onedr0p commented 5 years ago

Oracle has released 18.1.0.0.0 and the tap doesn't work which this version.

kaukas commented 5 years ago

Hi! Do you know what the problem is? Would you have time to prepare a PR?

onedr0p commented 5 years ago

I could put a PR together but I am unsure how to test, I haven't worked on homebrew projects before.

The link in your readme takes you to the latest version which is 18.1.0.0.0

https://www.oracle.com/technetwork/topics/intel-macsoft-096467.html

onedr0p commented 5 years ago

Here's a output from the console.

/Downloads  cp -r instantclient-basic-macos.x64-18.1.0.0.0.zip ~/Library/Caches/instantclient
/Downloads  cp -r instantclient-sqlplus-macos.x64-18.1.0.0.0.zip ~/Library/Caches/instantclient
/Downloads  brew tap InstantClientTap/instantclient
==> Tapping instantclienttap/instantclient
Cloning into '/usr/local/Homebrew/Library/Taps/instantclienttap/homebrew-instantclient'...
remote: Enumerating objects: 16, done.
remote: Counting objects: 100% (16/16), done.
remote: Compressing objects: 100% (14/14), done.
remote: Total 16 (delta 7), reused 6 (delta 1), pack-reused 0
Unpacking objects: 100% (16/16), done.
Tapped 9 formulae (51 files, 48.2KB).
 /Downloads  brew install instantclient-basic                                                                            (11s 726ms)
==> Installing instantclient-basic from instantclienttap/instantclient
Error: The package file can not be downloaded automatically. Please sign in
and accept the licence agreement on the Instant Client downloads page:

  http://www.oracle.com/technetwork/topics/intel-macsoft-096467.html

Then manually download this file:

  http://download.oracle.com/otn/mac/instantclient/122010/instantclient-basic-macos.x64-12.2.0.1.0-2.zip

To this location (a specific filename in homebrew cache directory):

  /Users/me/Library/Caches/Homebrew/downloads/665aa2952dd4fcdbbe25f6a02ee3cc8cf5b39ab36c8001447b303fe567cc8354--instantclient-basic-macos.x64-12.2.0.1.0-2.zip

An example command to rename and move the file into the homebrew cache:

  $ cd /path/to/downloads && mv instantclient-basic-macos.x64-12.2.0.1.0-2.zip /Users/dbuhl001/Library/Caches/Homebrew/downloads/665aa2952dd4fcdbbe25f6a02ee3cc8cf5b39ab36c8001447b303fe567cc8354--instantclient-basic-macos.x64-12.2.0.1.0-2.zip

Instead of renaming and moving you can create a symlink:

  $ cd /path/to/downloads && ln -sf $(PWD)/instantclient-basic-macos.x64-12.2.0.1.0-2.zip /Users/me/Library/Caches/Homebrew/downloads/665aa2952dd4fcdbbe25f6a02ee3cc8cf5b39ab36c8001447b303fe567cc8354--instantclient-basic-macos.x64-12.2.0.1.0-2.zip

Then re-run the installation:

  $ brew install instantclient-basic
Error: An exception occurred within a child process:
  SystemExit: exit
kaukas commented 5 years ago

Installation of 18.1.0.0.0 should work. Please let me know if there are any issues.