Optionally install packages for version 11g

InstantClientTap / homebrew-instantclient

A tap of Mac Homebrew formulas for Oracle Instant Client.

MIT License

80 stars 39 forks source link

Optionally install packages for version 11g #8

Closed laszpio closed 8 years ago

kaukas commented 8 years ago

Hello.

Thank you for the PR. I found one potential problem: fix_oracle_lib_path is not needed and was dropped for 12g in PR #7. I believe it is still needed for 11g, isn't it?

laszpio commented 8 years ago

I reinstalled using new formula without fix_oracle_lib_path and it worked fine; to simulate clean slate I removed all instantclient files from Cellar. Do you think there might still have been some dynamic links leftovers from the previous install and thus it worked fine?

laszpio commented 8 years ago

We don't need fix_oracle_lib_path for 11 too. I have tested the installation process on another machine which never had any version of instant client installed before. It is sufficient just to link like we do for 12.