Instinctlol / automatic-twitch-recorder

Checks if a user on twitch is currently streaming and then records the stream via streamlink
187 stars 40 forks source link

Directories #10

Closed maxb2 closed 5 years ago

maxb2 commented 5 years ago

Change the codebase to use objects. Add the ability to choose a recording directory and a final output directory.

Instinctlol commented 5 years ago

You added a lot of sugar, which is good. However, the new TwitchRecord.py file including the class TwitchUser doesn't make much sense.

So what I want is what I mentioned in #8. Basically there should be a checker which checks if a stream is online, and when it IS online, stop checking if it is online and spawn a new Thread which records said stream. When that Thread is done, the stream has to be checked again. The concept of threads may be too difficult for you at this point, but you can create a class OR function which has a stream/streamurl or something similar as an input with the purpose of recording it.

So my recommendation is to move the sugar (directories) to check.py and if you want to, you can implement the thing I mentioned above :)

Also a few more comments would be nice. At first, I had some trouble understanding the purpose of a final directory or recording directory.

EDIT: I'll probably start working on this again when I'm done with my thesis.