search

Institute-for-Future-Intelligence / multiphysics

Interactive Multiphysics Simulation for Everyone
https://intofuture.org/energy2d.html
GNU Lesser General Public License v3.0
58 stars 29 forks source link

Simulation bugs fixed, speed optimization #5

Closed AnaMarkH closed 3 years ago

AnaMarkH commented 7 years ago

Note: More details about the bugs and their impact on simulation results can be found in the file "energy2d_V2-9_Issues.pdf" which was added to the repository.

1) Bug fixed: object mapping Transfer of object shapes to the finite elements of the simulation field was wrong and introduced an artificial scale effect into simulation. Fixed by using finite element centers instead of blurry grid points for comparison with object shape.

2) Bug fixed: implicit solver implementation The implicit solver used for heat conductivity simulations introduced an artificial asymmetry into the simulation. Fixed by implementing an explicit solver and an adopted check for accurate time step length setting.

3) Bug fixed: floating point accuracy Limited floating point accuracy of heat conductivity simulations could introduce artificial equilibrium states into simulation. Fixed by using data type "double" instead of "float".

4) Improvement: Speed optimization Heat conductivity simulations use parallel computing and an optimized algorithm resulting in significant speed improvements (about 50% on my machine).

charxie commented 7 years ago

Hi Mark:

I just noticed your pull request. I rarely come to this page. I will review your request carefully and get back to you as soon as I can. I haven't been able to work on this project often.

Best regards, Charles