search

InstituteforDiseaseModeling / ckan

This is a fork of the official CKAN repository. This fork is being used for internal IDM purposes and not for public distribution. CKAN is an open-source DMS (data management system) for powering data hubs and data portals. CKAN makes it easy to publish, share and use data. It powers datahub.io, catalog.data.gov and europeandataportal.eu/data/en/dataset among many other sites.
http://ckan.org/
Other
0 stars 1 forks source link

test_string_literals_are_prefixed failed #6

Open MeWu-IDM opened 5 years ago

MeWu-IDM commented 5 years ago

This one complains on paster.py as well, maybe we should get rid of it 698 ''' 699 errors = [] 700 for abs_path, rel_path in walk_python_files(): 701 if rel_path in _STRING_LITERALS_WHITELIST: 702 continue 703 B-> problems = find_unprefixed_string_literals(abs_path) 704 if problems: 705 errors.append((rel_path, problems)) 706 if errors: 707 lines = [u'Unprefixed string literals:'] 708 for filename, problems in errors:

(Pdb) abs_path u'/home/ckan/src/ckan/contrib/windows-local/paster.py' (Pdb) find_unprefixed_string_literals(abs_path) [(7, 16), (8, 26), (8, 54)]

MeWu-IDM commented 5 years ago

check if it's still repro

DLukacevic-IDM commented 5 years ago

Added 'u' for strings in all .py files in IDM extension, except for the test code and the CKAN core files which are part of the windows-local setup.

Assigning to MeWu to address this for the test code.

MeWu-IDM commented 5 years ago

move to phase 2 as extra files will be removed and we may not have this issue