search

InstituteforDiseaseModeling / covasim

COVID-19 Agent-based Simulator (Covasim): a model for exploring coronavirus dynamics and interventions
https://covasim.org
MIT License
250 stars 223 forks source link

[UI] Support for Edge #184

Closed mfisher-idmod closed 4 years ago

mfisher-idmod commented 4 years ago

Describe the bug

This issue is to be addressed later, not now. Currently, the web app doesn't load properly in Edge. See screenshot.

To reproduce

Steps to reproduce the behavior:

For UI issues:

  1. Open up Edge
  2. Navigate to the covasim app in the browser

Expected behavior

Web app loads without issues in Edge

Screenshots or outputs

image

Platform (please complete the following information):

cliffckerr commented 4 years ago

Seems like Vue is just not rendering at all...

cliffckerr commented 4 years ago

@mfisher-idmod Are there any console errors? Does Edge have a console? :stuck_out_tongue:

cliffckerr commented 4 years ago

If it's not a quick fix, would suggest a user agent check and then "Please use Chrome or Firefox to use the Covasim app".

mfisher-idmod commented 4 years ago

@cliffckerr Console errors from Edge for target _top: sim

image

For "SCRIPT1028: SCRIPT1028: Expected identifier, string or number". Looks like it's this issue: https://github.com/vuetifyjs/vuetify/issues/8279

I'd be ok with the user agent check and message, if we were to deal with Edge later for government employees who still use IE/Edge.

lgeorge-idm commented 4 years ago

This is a one line fix. However, we'd have much better browser support if we were using Babel.