InstituteforDiseaseModeling / covasim

COVID-19 Agent-based Simulator (Covasim): a model for exploring coronavirus dynamics and interventions
https://covasim.org
MIT License
254 stars 223 forks source link

Applying Aggregrate Patterns on Immunity.py #336

Closed Utkarsh333 closed 2 years ago

Utkarsh333 commented 3 years ago

What my code does?

Although the immunity.py did have a built-in class to manage functions, the number of functions being called in other places without the necessary permissions provided me with the reasoning to apply aggregate patterns more thoroughly in this class.

What does it looks like?

Why is this a good idea? This pull request is an attempt for me to practice applying aggregate design patterns to established and reputed code libraries such as covasim. I'm a final-year computer science student so please highlight and correct the rookie mistakes I would have made. I hope this commit helps in moving this project further. :)

cliffckerr commented 2 years ago

Thanks for the PR -- we're not considering major architectural changes currently, but we appreciate the contribution to open-source software!