InstituteforDiseaseModeling / idmtools

https://docs.idmod.org/projects/idmtools/en/latest/
Other
4 stars 4 forks source link

Reduce requirements for idmtools-core #2126

Closed devclinton closed 5 months ago

devclinton commented 1 year ago

backoff>=1.10.0,<2.3 coloredlogs~=15.0 more-itertools~=9.0.0 pipreqs>=0.4.10,<0.5 tqdm>=4.52.0,<5 jinja2~=3.1.2 pygit2>=1.4.0,<=1.10.1 tabulate>=0.8.9,<0.10

devclinton commented 1 year ago

@devclinton - Document why this is needed This needs to move a major release.

We need to move most of this functions from core to cli.

Tqdm is the most difficult as we have to stub it out in core when not available

shchen-idmod commented 9 months ago

I can only move pygit2 package to cli. and pipreqs seems ok to remove completely. But rest of them are using by core and hard to remove backoff -- core/asset.py https://github.com/InstituteforDiseaseModeling/idmtools/blob/7e5196a0c8bfc20762bbff331845f344f511a081/idmtools_core/idmtools/assets/asset.py#L338 coloredlogs --core/logging.py https://github.com/InstituteforDiseaseModeling/idmtools/blob/7e5196a0c8bfc20762bbff331845f344f511a081/idmtools_core/idmtools/core/logging.py#L265 more-itertools --core/utils/collections.py https://github.com/InstituteforDiseaseModeling/idmtools/blob/7e5196a0c8bfc20762bbff331845f344f511a081/idmtools_core/idmtools/utils/collections.py#L9 tqdm is used in everywhere jinja2 -- core/plugins/item_sequence.py https://github.com/InstituteforDiseaseModeling/idmtools/blob/7e5196a0c8bfc20762bbff331845f344f511a081/idmtools_core/idmtools/plugins/item_sequence.py#L24 tabulate --cores/utils/display/displays.py https://github.com/InstituteforDiseaseModeling/idmtools/blob/7e5196a0c8bfc20762bbff331845f344f511a081/idmtools_core/idmtools/utils/display/displays.py#L8

ZDu-IDM commented 5 months ago

We did as much as we can so far.