search

InstituteforDiseaseModeling / idmtools

https://docs.idmod.org/projects/idmtools/en/latest/
Other
4 stars 4 forks source link

add_schdule_config should not hard code for num_cores and node_group #2318

Closed shchen-idmod closed 2 months ago

shchen-idmod commented 3 months ago

When we add workorder.json by dynamic method add_schedule_config: https://github.com/InstituteforDiseaseModeling/idmtools/blob/c956e6dacba02ee9246b1638f5fadd253fc1ad22/idmtools_platform_comps/idmtools_platform_comps/utils/scheduling.py#L130 add_schedule_config(simulation, command=command, node_group=node_group, num_cores=num_cores, **config_opts["config_opts"]

We should not set node_group and num_cores at all when do scheduling. Thanks @jps1 for pointing this out!

shchen-idmod commented 2 months ago

Fixed in 1.7.11 release