InstituteforDiseaseModeling / malaria-model_validation

1 stars 2 forks source link

Translate R plotting scripts into Python and add get_version.py #17

Closed YeChen-IDM closed 1 year ago

YeChen-IDM commented 2 years ago

5 scripts under review:

We will need to resolve some functions before we can run and test the main script, like the ~lm(), arrange(), etc.

Here is one of the plot from python script(please note that the ref_year is not grouped in the last plot): site_compare_incidence_age Here is the original plot from R scripts: site_compare_incidence_age

YeChen-IDM commented 2 years ago

Error about conflict dependencies when installing our package:

ERROR: Cannot install idmtools-cli and malaria-model-validation because these package versions have conflicting dependencies.
The conflict is caused by:
    datar 0.0.0 depends on pandas<2.0 and >=1.2
    plotnine 0.1.0 depends on pandas>=0.19.0
    idmtools 1.6.6 depends on pandas<1.2 and >=1.1.4

Pandas 1.2 is released on Dec 2020, not sure if idmtools can remove the requirement for pandas < 1.2

YeChen-IDM commented 2 years ago

Error about conflict dependencies when installing our package:

ERROR: Cannot install idmtools-cli and malaria-model-validation because these package versions have conflicting dependencies.
The conflict is caused by:
    datar 0.0.0 depends on pandas<2.0 and >=1.2
    plotnine 0.1.0 depends on pandas>=0.19.0
    idmtools 1.6.6 depends on pandas<1.2 and >=1.1.4

Pandas 1.2 is released on Dec 2020, not sure if idmtools can remove the requirement for pandas < 1.2

Clinton will remove this pandas<1.2 requirement in their upcoming release.

YeChen-IDM commented 2 years ago

Update Python plotting script according to R script fix in #19, commit 1713364, see details in #22

YeChen-IDM commented 1 year ago

Results in Python(left) vs. results in R(right): image