search

Instrumental / instrumental_agent-php

PHP Agent for Instrumental Application Monitoring
https://instrumentalapp.com
MIT License
8 stars 2 forks source link

Fix script/setup error #2

Closed tonydewan closed 6 years ago

tonydewan commented 6 years ago

script/setup fails because homebrew doesn't know about the PHP70 brew. We need to tap the relevant repository to make it findable.

mediocretes commented 6 years ago

:+1: but it is called script/setup

tonydewan commented 6 years ago

@janxious I also saw the composer.lock changes, but it doesn't seem reasonable for this change to have caused that to happen, so I didn't commit it. My (perhaps faulty) assumption is that we need to be more explicit about the versions of some of the dependencies. What do you think?

I had not run the tests before, but I do get a bunch of failures after running them. The same failures happen in master as well. I wonder if the dependency version changes caused this breakage?

tonydewan commented 6 years ago

@janxious I reset my local repo and ran script/setup but removed the last line (composer update). That stops the dependency updating which prevents the composer.lock file from changing. The tests still fail, though.

It seems like we shouldn't be updating dependencies every time someone runs script/setup. What do you think?

janxious commented 6 years ago

It seems like we shouldn't be updating dependencies every time someone runs script/setup. What do you think?

I agree, but also it doesn't seem to be the problem. I also think if we never update dependencies that is also bad.

tonydewan commented 6 years ago

I agree, but also it doesn't seem to be the problem.

We are aligned. :)

I propose we update this PR to remove the composer update line and investigate the test failures separately.

mediocretes commented 6 years ago

Closing in favor of #4 which removes some things but which still does composer update.