Instrumental / instrumentald

Instrumental System and Service Daemon
MIT License
14 stars 3 forks source link

Install systemd script with deb and fix related issues #75

Closed jason-o-matic closed 7 years ago

jason-o-matic commented 7 years ago

Previously in the deb the init.d script was included, but not the systemd script. FPM has an option for it, so this PR adds that option. This results in the systemd script being installed when you install the deb. That makes interfacing through puppet easier using Service.

This uncovered an issue with the previous systemd script where the log file option wasn't taking effect because the "foreground" command logged to stdout.

This PR also updates the systemd script to work around that issue.

tonydewan commented 7 years ago

I think the answer is no, but should this PR touch this file at all?

jason-o-matic commented 7 years ago

I think the answer is no, but should this PR touch this file at all?

I don't think so, and the tests pass without changing it. I think what will happen is that the after-install script will end up using the systemd file automatically (and directly) instead of relying on systemd magic to interface with the old init.d script.