search

Insubstantial / insubstantial

Swing look-and-feel library and assorted widgets
193 stars 57 forks source link

Added factory for creating a ribbon. #19

Closed erichschroeter closed 13 years ago

erichschroeter commented 13 years ago

Added RibbonFactory along with unit test and usage example. A minor patch to button layout menu tile level classes for checking for null button icons.

The RibbonFactory does not support 100% of the available features had someone manually create a ribbon and its components. The patch to CommandButtonLayoutManagerMenuTileLevel1 and CommandButtonLayoutManagerMenuTileLevel2 are required for the factory not to error when creating a ribbon application menu item.

I plan on implementing additional features the factory doesn't implement currently incrementally.

shemnon commented 13 years ago

Since I was planning on cutting a release later this week, I won't look into applying this until after I spin the release out. So that would put it in the Sept 2011 time frame for a release. Peraps this will give the time to get a more fluent interface for the contextual tab groups.

However, if you want to see the null tolerance code patched in, I would accept a patch consisting of just the code for the null button icons. This should allow for the existing factory code to work with the June 2011 release without needing to be merged in early.

erichschroeter commented 13 years ago

Ok, I'll submit the null tolerance code as a patch.

On Mon, Jun 27, 2011 at 4:08 PM, shemnon < reply@reply.github.com>wrote:

Since I was planning on cutting a release later this week, I won't look into applying this until after I spin the release out. So that would put it in the Sept 2011 time frame for a release. Peraps this will give the time to get a more fluent interface for the contextual tab groups.

However, if you want to see the null tolerance code patched in, I would accept a patch consisting of just the code for the null button icons. This should allow for the existing factory code to work with the June 2011 release without needing to be merged in early.

Reply to this email directly or view it on GitHub: https://github.com/Insubstantial/insubstantial/pull/19#issuecomment-1450458

erichschroeter commented 13 years ago

Since I am planning on submitting more code, I'd like to make sure the unit tests pass prior to submitting. As it is right now, I get 72 failures out of 227 runs, and 3 errors dealing with IconRibbonBandResizePolicy. Is this similar to what you get, or do you run the JUnit test cases?

On Mon, Jun 27, 2011 at 4:29 PM, Erich Schroeter erichschroeter@gmail.comwrote:

Ok, I'll submit the null tolerance code as a patch.

On Mon, Jun 27, 2011 at 4:08 PM, shemnon < reply@reply.github.com>wrote:

Since I was planning on cutting a release later this week, I won't look into applying this until after I spin the release out. So that would put it in the Sept 2011 time frame for a release. Peraps this will give the time to get a more fluent interface for the contextual tab groups.

However, if you want to see the null tolerance code patched in, I would accept a patch consisting of just the code for the null button icons. This should allow for the existing factory code to work with the June 2011 release without needing to be merged in early.

Reply to this email directly or view it on GitHub:

https://github.com/Insubstantial/insubstantial/pull/19#issuecomment-1450458

shemnon commented 13 years ago

I run the junits, and they seem to work for me. I'll reverify here in a bit.